Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splits resampleParams into two params #263

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Splits resampleParams into two params #263

merged 6 commits into from
Sep 6, 2024

Conversation

alexhroom
Copy link
Collaborator

see RascalSoftware/python-RAT#69 - this PR splits resampleParams into two parameters, resampleMinAngle and resampleNPoints.

@alexhroom
Fixed typos and test data
cfa1b0d 
fixed typo

hopefully all fixed?

fixed tests again
DrPaulSharp
DrPaulSharp approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@DrPaulSharp DrPaulSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, a few comments to consider.

API/controlsClass.m Outdated Show resolved Hide resolved
tests/testControlsClass.m Outdated Show resolved Hide resolved
tests/testControlsClass.m Show resolved Hide resolved
@alexhroom alexhroom merged commit b3cf660 into RascalSoftware:master Sep 6, 2024
5 checks passed
@alexhroom alexhroom deleted the split-resample-params branch September 6, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrPaulSharp DrPaulSharp DrPaulSharp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexhroom @DrPaulSharp